Revert size kwarg behaviour and make it work with Ellipsis#4667
Revert size kwarg behaviour and make it work with Ellipsis#4667michaelosthege wants to merge 3 commits intopymc-devs:v4from
size kwarg behaviour and make it work with Ellipsis#4667Conversation
pymc3/tests/test_transforms.py
Outdated
There was a problem hiding this comment.
All changes in this file are now back to pre-#4625
ac78af4 to
69e7f91
Compare
pymc3/distributions/multivariate.py
Outdated
There was a problem hiding this comment.
The Aesara MultinomialRV can do broadcasting since v2.0.4.
pymc3/tests/test_distributions.py
Outdated
There was a problem hiding this comment.
The parametrization sizes were changed such that the support shape (4,) does not occur in the size which should exclude the support. This way the test parametrization is slightly less confusing.
The broadcasting of the MultinomialRV does not change the fact that it has ndim_supp == 1.
|
The broadcasting of multivariate RVs is very weird already at the Aesara level: The above parametrization apparently gave it a 2-dimensional support? That's a problem, because the I noticed this when I tried to refactor the |
And don't use np.atleast_1d on things that can be tensors.
Corresponding tests were reverted, or edited to use other parametrization flavors. The Ellipsis feature now works with all three dimensionality kwargs. The MultinomialRV implementation was removed, because the broadcasting behavior was implemented in Aesara. Closes pymc-devs#4662
69e7f91 to
d4894a7
Compare
|
This can be rebased onto #4693 and, instead, re-introduce a non-breaking version of the |
|
Closing in favor of #4696. |
See #4662 for more information.
I will comment key changes in the diff.